use two channels to communicate mesos REVIVE #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
changed the title
justonedev1
force-pushed
the
multiple_revive_fix
branch
from
9d1be98
to
bd16a13
Compare
teo
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found why multiple mesos REVIVE commands can be issued. Sorry for the clutter in PR, but it is just automatic formater. The idea was to add
reviveOffersDonechannel to be used instead ofreviveOffersTrgfor sending acknowledgement when REVIVE call was done.I am not saying that it fixes OCTRL-777, just the issue of multiple REVIVE calls in one short time that we discussed Tuesday.