PWGHF: small fixes in charm baryon tasks #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZFederica
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
nzardosh,
NicoleBastid,
hahassan7 and
jpxrk
as code owners
fcatalan92
reviewed
Jun 11, 2024
fcatalan92
requested changes
Jun 11, 2024
Please consider the following formatting changes to AliceO2Group#6483
fcatalan92
reviewed
Jun 12, 2024
fcatalan92
reviewed
Jun 12, 2024
|
Hi @ZFederica, thanks for implementing my comments! I think that the MC event selection as it is implemented now is not configurable. I added a couple of comments with more details. |
fcatalan92
requested changes
Jun 13, 2024
Comment on lines
27
to
31
| #include "PWGHF/Core/CentralityEstimation.h" | ||
| #include "PWGHF/Core/SelectorCuts.h" | ||
| #include "PWGHF/DataModel/CandidateReconstructionTables.h" | ||
| #include "PWGHF/DataModel/CandidateSelectionTables.h" | ||
| #include "PWGHF/Utils/utilsEvSelHf.h" |
There was a problem hiding this comment.
The additional includes could be removed now
fcatalan92
approved these changes
Jun 13, 2024
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
Jun 13, 2024
* Fix bool and config * eta->y gen level info * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabio Catalano <[email protected]> * Remove unnecessary check * Switch to McEvSel func * Use hfEvSelMc func * Please consider the following formatting changes * Remove unnecessary code * Remove include * Remove include --------- Co-authored-by: Fabio Catalano <[email protected]> Co-authored-by: ALICE Action Bot <[email protected]>
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
* Fix bool and config * eta->y gen level info * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabio Catalano <[email protected]> * Remove unnecessary check * Switch to McEvSel func * Use hfEvSelMc func * Please consider the following formatting changes * Remove unnecessary code * Remove include * Remove include --------- Co-authored-by: Fabio Catalano <[email protected]> Co-authored-by: ALICE Action Bot <[email protected]>
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
* Fix bool and config * eta->y gen level info * Update PWGHF/TableProducer/candidateCreatorXic0Omegac0.cxx Co-authored-by: Fabio Catalano <[email protected]> * Remove unnecessary check * Switch to McEvSel func * Use hfEvSelMc func * Please consider the following formatting changes * Remove unnecessary code * Remove include * Remove include --------- Co-authored-by: Fabio Catalano <[email protected]> Co-authored-by: ALICE Action Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fcatalan92