PWGHF: D+h correlations - efficiency correction #6512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apalasciano
requested review from
alibuild,
vkucera,
fcolamar,
fgrosa,
fcatalan92,
mfaggin,
mmazzilli,
deepathoms,
nzardosh,
NicoleBastid,
hahassan7 and
jpxrk
as code owners
vkucera
previously requested changes
Jun 13, 2024
Comment on lines
131
to
132
| registry.add("hDeltaEtaPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaEta + "entries", {HistType::kTH1F, {{axisDeltaEta}}}), | ||
| registry.add("hDeltaPhiPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaPhi + "entries", {HistType::kTH1F, {{axisDeltaPhi}}}), |
There was a problem hiding this comment.
This won't compile. Please make sure your branch compiles before making a PR.
Suggested change
| registry.add("hDeltaEtaPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaEta + "entries", {HistType::kTH1F, {{axisDeltaEta}}}), | |
| registry.add("hDeltaPhiPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaPhi + "entries", {HistType::kTH1F, {{axisDeltaPhi}}}), | |
| registry.add("hDeltaEtaPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaEta + "entries", {HistType::kTH1F, {{axisDeltaEta}}}); | |
| registry.add("hDeltaPhiPtIntSignalRegion", stringDHadron + stringSignal + stringDeltaPhi + "entries", {HistType::kTH1F, {{axisDeltaPhi}}}); |
There was a problem hiding this comment.
Sorry, it does compile. It just does something slightly different. :-)
vkucera
reviewed
Jun 13, 2024
Comment on lines
115
to
117
| HistogramRegistry registry{"registry", {}, OutputObjHandlingPolicy::AnalysisObject}; | ||
|
|
||
| Filter dplusFilter = ((o2::aod::hf_track_index::hfflag & static_cast<uint8_t>(1 << aod::hf_cand_3prong::DecayType::DplusToPiKPi)) != static_cast<uint8_t>(0)) && aod::hf_sel_candidate_dplus::isSelDplusToPiKPi >= selectionFlagDplus; |
There was a problem hiding this comment.
Please keep the registry last.
vkucera
reviewed
Jun 13, 2024
| @@ -141,6 +141,8 @@ struct HfCorrelatorDplusHadrons { | |||
|
|
|||
| Configurable<int> selectionFlagDplus{"selectionFlagDplus", 7, "Selection Flag for Dplus"}; // 7 corresponds to topo+PID cuts | |||
| Configurable<int> applyEfficiency{"applyEfficiency", 1, "Flag for applying D-meson efficiency weights"}; | |||
| Configurable<std::vector<double>> binsPtEfficiencyD{"binsPtEfficiencyD", std::vector<double>{o2::analysis::hf_cuts_dplus_to_pi_k_pi::vecBinsPt}, "pT bin limits for efficiency"}; | |||
| Configurable<std::vector<double>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; | |||
There was a problem hiding this comment.
Suggested change
| Configurable<std::vector<double>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; | |
| Configurable<std::vector<float>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; |
vkucera
reviewed
Jun 13, 2024
Comment on lines
78
to
79
| Configurable<std::vector<double>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; | ||
| Configurable<std::vector<double>> efficiencyHad{"efficiencyHad", {1., 1., 1., 1., 1., 1.}, "efficiency values for associated particles"}; |
There was a problem hiding this comment.
Suggested change
| Configurable<std::vector<double>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; | |
| Configurable<std::vector<double>> efficiencyHad{"efficiencyHad", {1., 1., 1., 1., 1., 1.}, "efficiency values for associated particles"}; | |
| Configurable<std::vector<float>> efficiencyD{"efficiencyD", {1., 1., 1., 1., 1., 1.}, "efficiency values for D+ meson"}; | |
| Configurable<std::vector<float>> efficiencyHad{"efficiencyHad", {1., 1., 1., 1., 1., 1.}, "efficiency values for associated particles"}; |
|
Hi Antonio, I'm generally ok with this PR. As discussed in private we can refine the associated pt ranges,.but this can be done at a later stage. |
fcolamar
approved these changes
Jun 13, 2024
fcolamar
dismissed
vkucera’s stale review
Suggested changes implemented by the author
christianreckziegel
pushed a commit
to christianreckziegel/O2Physics
that referenced
this pull request
Jun 13, 2024
* PWGHF: D+h Corr - efficeincy correction * Fix * removal not needed brackets * Fixes
GiorgioAlbertoLucia
pushed a commit
to GiorgioAlbertoLucia/O2Physics
that referenced
this pull request
Jul 9, 2024
* PWGHF: D+h Corr - efficeincy correction * Fix * removal not needed brackets * Fixes
echizzal
pushed a commit
to echizzal/O2Physics
that referenced
this pull request
Jul 18, 2024
* PWGHF: D+h Corr - efficeincy correction * Fix * removal not needed brackets * Fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
D+ - h correlation task: