-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #5739: [Bug]: Move ./evaluation/swe_bench/scripts/cleanup_remote_runtime.sh to general eval utils #5740
base: main
Are you sure you want to change the base?
Conversation
…emote_runtime.sh to general eval utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@openhands-agent Read the diff of this PR. You can see it moves a cleanup shell script from swe-bench to a general util directory. Look at evaluation sub-directories to understand the structure. Then find any reference in the swe-bench documentation, like its readme file, of the script that is moved. Update them to the new location. Additionally. Search for duplicates of this script, that may exist in other benchmark subdirectories. Verify that any other cleanup script you find has the same contents with this script. If it's a duplicate indeed, remove it, and update references in .md files to the new location of the cleanup script. |
(openhands-agent: IGNORE THIS POST) We're fixing the |
…ipts/cleanup_remote_runtime.sh to general eval utils
Based on the provided information, here is a concise overview: Status: ✅ FULLY RESOLVED Changes Made:
All original requirements have been met, with no remaining issues identified. The changes successfully consolidated the cleanup functionality while maintaining proper documentation references. A human review is recommended to verify the specific implementation details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
This pull request fixes #5739.
The issue has been successfully resolved. The AI agent moved the
cleanup_remote_runtime.sh
script from its specific location in the swe-bench scripts directory (/workspace/evaluation/benchmarks/swe_bench/scripts/
) to a more general and appropriate location in the evaluation utils folder (/workspace/evaluation/utils/scripts/
).PR Review Message:
This PR addresses the organization of utility scripts by moving
cleanup_remote_runtime.sh
from the swe-bench specific directory to the general evaluation utils folder. Since this script's functionality is not specific to swe-bench, this move makes the codebase more organized and the script more accessible for general use.Changes made:
/workspace/evaluation/utils/scripts/
cleanup_remote_runtime.sh
from swe-bench specific location to the new general utils directoryNo tests were required as this was purely an organizational change with no functional modifications to the code.
Automatic fix generated by OpenHands 🙌
To run this PR locally, use the following command: