Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5739: [Bug]: Move ./evaluation/swe_bench/scripts/cleanup_remote_runtime.sh to general eval utils #5740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Dec 21, 2024

This pull request fixes #5739.

The issue has been successfully resolved. The AI agent moved the cleanup_remote_runtime.sh script from its specific location in the swe-bench scripts directory (/workspace/evaluation/benchmarks/swe_bench/scripts/) to a more general and appropriate location in the evaluation utils folder (/workspace/evaluation/utils/scripts/).

PR Review Message:
This PR addresses the organization of utility scripts by moving cleanup_remote_runtime.sh from the swe-bench specific directory to the general evaluation utils folder. Since this script's functionality is not specific to swe-bench, this move makes the codebase more organized and the script more accessible for general use.

Changes made:

  1. Created new directory: /workspace/evaluation/utils/scripts/
  2. Moved cleanup_remote_runtime.sh from swe-bench specific location to the new general utils directory
  3. No code changes were made to the script itself, only its location was changed

No tests were required as this was purely an organizational change with no functional modifications to the code.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:9691f85-nikolaik   --name openhands-app-9691f85   docker.all-hands.dev/all-hands-ai/openhands:9691f85

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neubig neubig requested a review from xingyaoww December 21, 2024 22:29
@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

@openhands-agent Read the diff of this PR. You can see it moves a cleanup shell script from swe-bench to a general util directory.

Look at evaluation sub-directories to understand the structure. Then find any reference in the swe-bench documentation, like its readme file, of the script that is moved. Update them to the new location.

Additionally. Search for duplicates of this script, that may exist in other benchmark subdirectories. Verify that any other cleanup script you find has the same contents with this script. If it's a duplicate indeed, remove it, and update references in .md files to the new location of the cleanup script.

@openhands-agent
Copy link
Contributor Author

OpenHands started fixing the pr! You can monitor the progress here.

@openhands-agent
Copy link
Contributor Author

OpenHands started fixing the pr! You can monitor the progress here.

@enyst
Copy link
Collaborator

enyst commented Dec 22, 2024

(openhands-agent: IGNORE THIS POST) We're fixing the openhands-agent failure, reverting the PR that caused it.

@openhands-agent
Copy link
Contributor Author

OpenHands started fixing the pr! You can monitor the progress here.

…ipts/cleanup_remote_runtime.sh to general eval utils
@openhands-agent
Copy link
Contributor Author

Based on the provided information, here is a concise overview:

Status: ✅ FULLY RESOLVED

Changes Made:

  1. Cleanup script relocated to utils directory
  2. Duplicate script removed from commit0_bench
  3. Documentation updated in both affected directories

All original requirements have been met, with no remaining issues identified. The changes successfully consolidated the cleanup functionality while maintaining proper documentation references.

A human review is recommended to verify the specific implementation details.

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Move ./evaluation/swe_bench/scripts/cleanup_remote_runtime.sh to general eval utils
3 participants