-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak log levels #4729
Tweak log levels #4729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I explicitly do not want actions and observations in the info logs--will follow up
@enyst we need to keep actions and observations out of the default I'd support having an env var that swaps them from debug into info though, like |
Okay. Oh, this is an issue on the hosted version, I suppose? On local it looks really strange to not tell the user anything. Env var sounds good. |
Yeah I'd say it's an issue in any kind of multi-tenant environment. Also, ideally, the UI would give you all this information, and the server logs should really just be there to know "is the server functioning properly." I think right now it's kind of a hacky way to gain the level of agent observability we want in the UI but don't have. |
On further thought, we already have other env vars changing the logging behavior, like LOG_TO_FILE and SKIP_CONTAINER_LOGS somewhere, adding another is not helping predictability. FWIW maybe I didn't lose track yet, but it's going to happen. 😅 Does this work though as a temporary measure? I think we need to think this over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unblocking but left one comment!
End-user friendly description of the problem this fixes or functionality that this introduces
Restore visible logs for each action and observation when ran locally.
Give a summary of what the PR does, explaining any non-trivial design decisions
This PR proposes a few tweaks for log levels:
info
the action and the obs (ref slack) whenLOG_ALL_EVENTS
env var is setgithub.py
since that is not active in most use cases and on local it sounds like something's wrong.Link of any specific issues this addresses
To run this PR locally, use the following command: