Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix double websocket connection in dev mode #5790

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rbren
Copy link
Collaborator

@rbren rbren commented Dec 24, 2024

End-user friendly description of the problem this fixes or functionality that this introduces

  • Include this change in the Release Notes. If checked, you must provide an end-user friendly description for your change below
    no changelog

Give a summary of what the PR does, explaining any non-trivial design decisions

In dev mode, the WebSocket connection gets created twice. Seems like this logic broke with the recent refactor--the changes now close the first socket that opens properly


Link of any specific issues this addresses


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:45713cc-nikolaik   --name openhands-app-45713cc   docker.all-hands.dev/all-hands-ai/openhands:45713cc

@rbren rbren marked this pull request as ready for review December 24, 2024 17:38
@rbren rbren changed the title fix up double connection fix up double websocket connection in dev mode Dec 24, 2024
@rbren rbren changed the title fix up double websocket connection in dev mode fix double websocket connection in dev mode Dec 24, 2024
@rbren rbren enabled auto-merge (squash) December 24, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant