Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #5806: Tooltips for navbar #5807

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

openhands-agent
Copy link
Contributor

@openhands-agent openhands-agent commented Dec 26, 2024

This pull request fixes #5806.

The PR successfully addresses the original issue by implementing tooltips for all navbar icons. The solution:

  1. Created a reusable TooltipButton component for consistency
  2. Added descriptive tooltips to all navbar items including:
    • Settings
    • Documentation
    • New project
    • All Hands Logo
    • User avatar

This matches the requested UX improvement of showing explanatory text when users hover over navbar icons, making the interface more user-friendly and self-explanatory. The implementation uses NextUI's Tooltip component, which is a standard approach for this UI pattern, and the tests are passing. The solution appears to be complete and addresses all aspects of the original issue request.

This PR can be recommended for review as it provides a comprehensive solution to the navigation clarity problem while maintaining code quality and test coverage.

Automatic fix generated by OpenHands 🙌


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:61cf217-nikolaik   --name openhands-app-61cf217   docker.all-hands.dev/all-hands-ai/openhands:61cf217

Copy link
Contributor

@neubig neubig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, confirmed that tooltips are working.
Screenshot 2024-12-26 at 12 40 30 AM

Need a second review.

@neubig neubig marked this pull request as ready for review December 26, 2024 05:43
@neubig neubig requested a review from amanape December 26, 2024 05:43
@neubig neubig removed the lint-fix label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips for navbar
2 participants