Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chan_simpleusb, chan_usbradio: Add parameter to make scaling/clipping optional, fix issue #399 #418

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Commits on Sep 6, 2024

  1. Add RX Audio Statistics and ADC Clip Detection feature. This adds a n…

    …ew rxaudiostats parameter to simpleusb.conf, which enables a new function check_rx_audio() in chan_simpleusb.c to be called during processing of received USB audio frames. If ADC clipping is then detected GPIO4 is set for 500mS to support illumination of a node / audio interface Clip LED. Statistics collected also include peak and average RMS audio levels averaged over the previous 1 second, which can be displayed from the simpleusb-tune-menu 'R' option or AMI 'susb tune menu-support a' function.
    davidgsd committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    40b886a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Move rxaudiostats functions to ../res/res_usbradio.c, add 'ast_radio_…

    …' prefix to function names. Change rxaudiostats conf parameter name to 'checkrxaudio' and type to int, with value indicating GPIO# to use (or 0 to disable feature), validate value in hidhdwconfig()
    davidgsd committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    e8f00d0 View commit details
    Browse the repository at this point in the history
  2. Add Rx Audio Stats and Clip Detect feature support to chan_usbradio.c…

    …. Update susb tune-menu options to be consistent with that of usbradio. Default checkrxaudio conf param to off for usbradio. Add 'TBR' comments on some old sections of code that are present in both chan_simpleusb.c and chan_usbradio.c that will cause digital clipping of tx audio.
    davidgsd committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    84644e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    efe18d8 View commit details
    Browse the repository at this point in the history
  2. Removed unused variable.

    davidgsd committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    55cf18a View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    22bc47f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74dd2e6 View commit details
    Browse the repository at this point in the history
  3. Rename checkrxaudio parameter to clipledgpio (which specifies the GPI…

    …O pin to use for the ADC Clip Detect Feature (0=disabled)). Set default value of clipledgpio to disabled in chan_[simpleusb|usbradio].c (so writing to a GPIO won't be automatically enabled during ASL updates), but enabled in configs/rpt/simpleusb.conf.
    davidgsd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7d66fc6 View commit details
    Browse the repository at this point in the history
  4. whitespace updates.

    davidgsd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    217634b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c1d0d88 View commit details
    Browse the repository at this point in the history
  6. whitespace cleanup.

    davidgsd committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a68ca64 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. re-enable scaling code in chan_simplusb and usbradio that scales the …

    …raw Tx audio by 1.1 and (usbradio only) scales raw Rx audio by 0.8. (This code should marked TBR should be removed asap as described in issue AllStarLink#399.) Move call to check_rx_audio() to above where the 0.8 rx audio scaling is done in chan_usbradio.c.
    davidgsd committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    67859d1 View commit details
    Browse the repository at this point in the history
  2. consider 0 a valid file descriptor value in ast_radio_print_rx_audio_…

    …stats() per review comment
    davidgsd committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    c9d1b41 View commit details
    Browse the repository at this point in the history
  3. update ast_radio_print_rx_audio_stats() function header comment to cl…

    …arify that it will print using ast_verbose() if passed in fd < 0
    davidgsd committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    5a30d09 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Configuration menu
    Copy the full SHA
    6d3bece View commit details
    Browse the repository at this point in the history
  2. Fix issue AllStarLink#415

    davidgsd committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    70683d2 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Configuration menu
    Copy the full SHA
    0ebd611 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Fix issue AllStarLink#399, add legacyaudioscaling parameter to allow …

    …scaling/clipping code to remain unchanged for existing installs or if user enables parameter in simpleusb/usbradio .conf.
    davidgsd committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1ce8306 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a476a0b View commit details
    Browse the repository at this point in the history
  3. whitespace cleanups

    davidgsd committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    889be41 View commit details
    Browse the repository at this point in the history