Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add define for memcmp #25

Merged
merged 1 commit into from
Nov 3, 2024
Merged

Conversation

nicholasbishop
Copy link
Contributor

As of 8b3c9fb, InstrProfilingPlatformWindows.c uses memcmp. Define memcmp via a macro to avoid a "call to undeclared library function" error.

As of 8b3c9fb,
InstrProfilingPlatformWindows.c uses memcmp. Define memcmp via a macro
to avoid a "call to undeclared library function" error.
@nicholasbishop
Copy link
Contributor Author

nicholasbishop commented Nov 2, 2024

I think the UEFI test job failure is due to a recent change in cc, looking into it.

Edit: should be fixed by rust-lang/cc-rs#1263

@Amanieu Amanieu merged commit 01fb9b6 into Amanieu:master Nov 3, 2024
5 of 6 checks passed
@nicholasbishop nicholasbishop deleted the bishop-add-memcmp branch November 3, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants