Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add album #31

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Feature/add album #31

merged 2 commits into from
Sep 12, 2023

Conversation

CesarHerr
Copy link
Collaborator

- In this pull request the following features were created:

  • List all music albums

  • Add a music album

  • The following options should be available:

  • List all genres (e.g 'Comedy', 'Thriller')

@CesarHerr CesarHerr added the enhancement New feature or request label Sep 12, 2023
@CesarHerr CesarHerr self-assigned this Sep 12, 2023
Copy link
Collaborator

@Zven94 Zven94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @CesarHerr 👋🏻👋🏻

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • No Linters errors 🔥
  • Great job working on the setup💯
  • Followed Gitflow 🔥
  • Menu options currently working: List all music albums, Add a music album, List all genres (e.g 'Comedy', 'Thriller').

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@CesarHerr CesarHerr merged commit c21ebcb into develop Sep 12, 2023
1 check passed
@CesarHerr CesarHerr deleted the feature/addAlbum branch September 12, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants