Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book class #32

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Book class #32

merged 6 commits into from
Sep 12, 2023

Conversation

AndreaM2429
Copy link
Owner

Hello there, I implement new features that I'd like to merge into the develop branch. Thanks in advance for taking the time to review my code.

Milestones:

  • Create a Book class in a separate .rb file.
  • All Book class properties visible in the diagram are defined and set up in the constructor method.
  • method can_be_archived? that overrides the method from the parent class should return true if the parent's method returns true OR if cover_state equals "bad" otherwise, it should return false
  • The following options are available in the App class:
    • List all books
    • Add a book

Copy link
Collaborator

@CesarHerr CesarHerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndreaM2429 ,

STATUS: APPROVED! 🥇 💯

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

done

Highlights

  • Great job with your book class 👍
  • Great job with your methods implementation 👍
  • Nice work you meet all the requirements 🥇
  • All linters passed ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@AndreaM2429 AndreaM2429 merged commit 714cafc into develop Sep 12, 2023
1 check passed
@AndreaM2429 AndreaM2429 deleted the book-class branch September 12, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5pt] Implement methods in Book class - Team member #1 [0.5pt] Book class - Team member #1
2 participants