Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Label class and implement methods #33

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

AndreaM2429
Copy link
Owner

Hello there, I implemented new features to resolve the list requirements, and I'd like to merge them into the develop branch. Thanks in advance for taking the time to review my code.

Milestones:

  • Create a Label class with an association to the Item class in a separate .rb file.
  • All Label class properties visible in the diagram are defined and set up in the constructor method.
  • method add_item that takes an instance of the Item class as an input, adds the input item to the collection of items and adds self as a property of the item object
  • The following options are available in the App class:
    • List all labels

Solve #5 #6

Copy link
Collaborator

@Zven94 Zven94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢 🥇 💯

success

Hey @AndreaM2429 👋

Great work on implementing the Book Class and its metohds. Your task are complete. 😊
There is nothing else to say about your project: lets merge it 👍

Highlights 🥇

✔️ Descriptive Pull Request Title & info
✔️ Linters running
✔️ Label class in another file and all properties defined
✔️ can_be_archived?() Method correctly implemented
✔️ App Class functionalities correctly working: create_book; list_all_books
✔️ Add item method currently working

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@AndreaM2429 AndreaM2429 merged commit 7a22b3e into develop Sep 13, 2023
1 check passed
@AndreaM2429 AndreaM2429 deleted the label-class branch September 13, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.5pt] Implement methods in Label class - Team member #1 [0.5pt] Label class - Team member #1
2 participants