Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve book/label #40

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Preserve book/label #40

merged 5 commits into from
Sep 14, 2023

Conversation

AndreaM2429
Copy link
Owner

Hi there! I implemented a new feature that I'd like to merge into the develop branch.
Thanks in advance for the feedback and the time to review my code.

Milestones:

  • All data from Book and Label classes should be preserved by saving collections in .json files.
  • The app is working as expected
  • Menu options were modified

@AndreaM2429 AndreaM2429 linked an issue Sep 14, 2023 that may be closed by this pull request
Copy link
Collaborator

@CesarHerr CesarHerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AndreaM2429 ,

STATUS: APPROVED! 🥇 💯

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:

done

Highlights

  • Great job Preserving data 👍
  • All linters passed ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@AndreaM2429 AndreaM2429 merged commit ec9f5af into develop Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2.5pt] Preserve data - Team member #1
2 participants