Pull-Request: Catalog of my things

[Zven94]

Catalog Of My Things

In this project, the team has created a console app that help you to keep a record of different types of things you own, like: books, music albums, movies, and games. Everything is based on the UML class diagram presented below. The data can be stored in JSON files also.

Demo of the app:

Demo

Files added:

• app.rb
• author.rb
• book.rb
• game.rb
• genre.rb
• item.rb
• label.rb
• main.rb
• music_album.rb
• preserve_album.rb
• preserve_author.rb
• preserve_book.rb
• preserve_game.rb
• preserve_label.rb
• schema.sql

Tests:

in the spec folder:

• author_spec.rb
• book_spec.rb
• game_spec.rb
• genre_spec.rb
• label_spec.rb
• music_album_spec.rb

[iambenkis]

Hi @Zven94 , @CesarHerr , @AndreaM2429

Good job so far!
There are some issues that you still need to work on to prepare your project for the final evaluation but you are almost there!
You did a great job, keep up the good work 👍🏼

Highlights

✔️ All tasks are implemented
✔️ All tests are passing
✔️ The UI meet the requirements
✔️ Your project preserve data successfully

Suggested changes

• Good job creating your Ruby capstone project 👏 👏 . Everything works as required. Also, you provided a video where you presented the UI of your project , and some pieces of codes However, you should provide a video presentation that have the follow details 🥇

1. The video should contain a clear and objective description of the project in professional English.
2. The maximum length of the video should 5 minutes. ✔️

Kindly re-take the video and ensure it contains all the requirements 👍

Check the comments under the review.

You can use as many of my suggestions as you want. If there is anything you would like to skip - feel free to do that. However, I strongly recommend you to take them into account as they can make your code better._

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question, so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

[Zven94]

@iambenkis Thank you so much for your review. Could you pleas give us a detail list of the requeriments for the video? We Just have 5 mins and I think that is a little bit hard to explain all the code in detail in that time.
We, split the video in 3 parts, first an intro making an explanation about the project then a demo of how to use it and then some hightlights of the project.

Theses are the requeriments of the video:
A description of the project.
A demo of the project features.
You should also highlight some interesting piece of code or something you built that you are very proud of.
You all should appear in the video and talk about the project.

[VICTOR-CHUKWU]

Hi Team,

STATUS: APPROVED! 🥇 💯

In my opinion, your project is ready for the presentation! There is nothing else to say other than... it's time to merge it

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.