Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

feat(ci): move to mc-modpack-kit #4

Merged
merged 18 commits into from
Sep 27, 2023
Merged

feat(ci): move to mc-modpack-kit #4

merged 18 commits into from
Sep 27, 2023

Conversation

jh-devv
Copy link
Collaborator

@jh-devv jh-devv commented Aug 30, 2023

No description provided.

@jh-devv jh-devv added the enhancement New feature or request label Aug 30, 2023
@jh-devv
Copy link
Collaborator Author

jh-devv commented Aug 30, 2023

@Aninuscsalas You have to set the Modrinth ID and TOKEN in the settings
Also allow "Allow PR's to be managed with actions"

@jh-devv
Copy link
Collaborator Author

jh-devv commented Aug 30, 2023

@Aninuscsalas Can't maybe yet merge cause ParadigmMC/mc-modpack-kit#49

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 15, 2023

@Aninuscsalas This should be pretty much complete (still have to add some stuff) but I want to ask something:

Does the version of the pack need to be different for the Forge and Quilt version?
Because for that, we would need ParadigmMC/mc-modpack-kit#49

@Aninuscsalas
Copy link
Owner

Does the version of the pack need to be different for the Forge and Quilt version? Because for that, we would need jh-devv/mc-modpack-kit#49

I'm still not sure what to do. I think its better to wait because in my test repos modrinth publishing/builing often fails, or skips everything. Im going to some testing with other packs before this one gets merged

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 15, 2023

Hmm, weird? Have you read the README?

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 17, 2023

Does the version of the pack need to be different for the Forge and Quilt version? Because for that, we would need jh-devv/mc-modpack-kit#49

I'm still not sure what to do. I think its better to wait because in my test repos modrinth publishing/builing often fails, or skips everything. Im going to some testing with other packs before this one gets merged

Could you share a test repo of yours?

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 21, 2023

@Aninuscsalas First, sorry for so late response!
I got it working? Perhaps you had older releases but it just works fine? Can yoy recheck this?

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 21, 2023

This theorically should be now working (the release please things just means you can bump one part of the monorepo)
Shoudl work!

@Aninuscsalas
Copy link
Owner

This theorically should be now working (the release please things just means you can bump one part of the monorepo) Shoudl work!

Should we try merging it? I have added the secrets to the repo. I guess the versioning can restart from 0.1.0... Im still not sure how should i style commit names, chore(quilt):, and feat(forge): can work fine but im not sure that listing all the updated mods separately or just saying "Updated mods" is a better idea.

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 21, 2023

Should we try merging it? I have added the secrets to the repo. I guess the versioning can restart from 0.1.0... Im still not sure how should i style commit names, chore(quilt):, and feat(forge): can work fine but im not sure that listing all the updated mods separately or just saying "Updated mods" is a better idea.

@Aninuscsalas Yea, but you could just try to run the version workflow right away and set it to just some value (e.g. fabric, it does not support currentry different versions for different components) and for the version set 0.1.0 if you want that!

And for the mod commits, I would use it like:
For updates:
chore(fabric): Update mods
For bigger mod changes (e.g. adding or removing)
feat(fabric): Added mods or feat(fabric): Added Fabric API
Its pretty much how'd you like it!

Hope this helps
jh-devv

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 26, 2023

@Aninuscsalas Now my project uses commits like

  • feat(modpack/<mod>): <description> for adding new features, configs or content.
  • chore(modpack/<mod>): <description> for routine maintenance tasks or cleanups.
  • update(modpack/<mod>): update <mod> for updating mods to newer versions.
  • mod(modpack/<mod>): add <mod> for introducing new mods to the modpack.

@Aninuscsalas
Copy link
Owner

I'm gonna probably try to merge this this in the next few days 🙃

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 27, 2023

@Aninuscsalas now just run the set version workflow ;3

@Aninuscsalas
Copy link
Owner

@Aninuscsalas now just run the set version workflow ;3

can i do that before merging? (im new to github)

@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 27, 2023

@Aninuscsalas now just run the set version workflow ;3

can i do that before merging? (im new to github)

You can do it right after or I can do it :3

@Aninuscsalas Aninuscsalas merged commit f92ab02 into main Sep 27, 2023
@jh-devv
Copy link
Collaborator Author

jh-devv commented Sep 27, 2023

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants