add two proverbs ... #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... about complexity, language and abstraction
|
these two last ones aren't really proverbs. I like your take on the first one, please refactor so this can merge the first one in. |
|
Maybe you can help me with that. How do I split a single, existing commit in two, so that I can extract the one, you like to have? |
remote the two proverbs, that will not be merged.
|
Now I simply removed the two proverbs that you did not want to merge and made a new commit. |
|
I think Git[hub] just gave us 2 more proverbs:
|
|
@rvzzz can you add those as a separate PR? 😆 And @cdonat if you resolve the conflicts, I'll merge it right away. Sorry for the 4 years of delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... about complexity, language and abstraction