-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update workflow translation-updates-to-main-repo #137
base: translation-files
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not against moving the creation of top- and second-level pages to a bash script, but I wouldn't know if all the environment variables & folder jumping would still work as expected. So I'd rather not touch it in that sense.
👍
done | ||
done | ||
# sub-level files | ||
documentation_groups=(automation general getting-started playback podcasters-hosters queue subscriptions) | ||
documentation_groups=(automation general getting-started playback podcasters-hosters queue subscriptions bugs-first-aid) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it could just take all folder names. Something like this (untested) could work:
documentation_groups=(automation general getting-started playback podcasters-hosters queue subscriptions bugs-first-aid) | |
documentation_groups=$(find ../_documentation -mindepth 1 -maxdepth 1 -type d | sed 's#../_documentation/##g') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work. Needs some further thoughts.
I have corrected indention and removed stuff I had included for debugging. I'm not against moving the creation of top- and second-level pages to a bash script, but I wouldn't know if all the environment variables & folder jumping would still work as expected. So I'd rather not touch it in that sense.
Once merged into the translation-files branch, it should probably also be applied to the master branch (for the manually triggered runs).