Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Really open disk as read only and do not use encrypted_volume_size metadata #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benjarobin
Copy link

I am sharing these 2 commits:

  • In my personal use case, I only mount as read-only the bitlocker volume, and I wanted to be sure that there will not have any modification to the volume. So open the disk device as requested by command line arguments
  • After shrinking the bitlocker volume using "Disk Management" Windows 10 version 1909, the encrypted_volume_size metadata field is not updated, so do not trust it... Use instead the partition size.

@haobinnan
Copy link
Contributor

It is not recommended to merge regarding the modification of encrypted_volume_size, as the value will not be updated when shrinking Bitlocker. That does not have any effect. If the Bitlocker is extended, the value will be updated automatically.
In addition, it is not recommedended to use ioctl. If it is an image file, then it is meaningless to use ioctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants