Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove global config and flatten [APE-1455] #14

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

fubuloubu
Copy link
Member

What I did

There's now a global config by default for every plugin that gets combined automatically, so it doesn't make sense to have the old config

Also flattening the old config file is a bit more friendly

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title refactor!: remove global config and flatten refactor!: remove global config and flatten [APE-1455] Oct 11, 2023
@linear
Copy link

linear bot commented Oct 11, 2023

APE-1455 "refactor!: remove global config and flatten" (ApeWorX/ape-addressbook #14)

What I did

There's now a global config by default for every plugin that gets combined automatically, so it doesn't make sense to have the old config

Also flattening the old config file is a bit more friendly

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ApeWorX/ape-addressbook #14 by fubuloubu on GitHub

via LinearSync

@fubuloubu fubuloubu force-pushed the refactor/remove-global-and-flatten branch from d2a811e to 1fc1e1d Compare October 11, 2023 01:23
@fubuloubu
Copy link
Member Author

fubuloubu commented Oct 11, 2023

Note: breaking change for v0.7

also consider bundling as 1st class into ape core

@fubuloubu fubuloubu force-pushed the refactor/remove-global-and-flatten branch from 491e0ee to 58e9ece Compare October 13, 2023 15:22
antazoey
antazoey previously approved these changes Dec 12, 2023
@antazoey antazoey enabled auto-merge (squash) December 12, 2023 18:15
@antazoey antazoey merged commit 771814a into main Dec 12, 2023
22 checks passed
@antazoey antazoey deleted the refactor/remove-global-and-flatten branch December 12, 2023 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants