generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: remove global config and flatten [APE-1455] #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
refactor!: remove global config and flatten
refactor!: remove global config and flatten [APE-1455]
Oct 11, 2023
APE-1455 "refactor!: remove global config and flatten" (ApeWorX/ape-addressbook #14)
What I didThere's now a global config by default for every plugin that gets combined automatically, so it doesn't make sense to have the old config Also flattening the old config file is a bit more friendly How I did itHow to verify itChecklist
ApeWorX/ape-addressbook #14 by fubuloubu on GitHub via LinearSync |
fubuloubu
force-pushed
the
refactor/remove-global-and-flatten
branch
from
October 11, 2023 01:23
d2a811e
to
1fc1e1d
Compare
Note: breaking change for v0.7 also consider bundling as 1st class into ape core |
fubuloubu
force-pushed
the
refactor/remove-global-and-flatten
branch
from
October 13, 2023 15:22
491e0ee
to
58e9ece
Compare
antazoey
previously approved these changes
Dec 12, 2023
antazoey
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
There's now a global config by default for every plugin that gets combined automatically, so it doesn't make sense to have the old config
Also flattening the old config file is a bit more friendly
How I did it
How to verify it
Checklist