Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow working without connection #24

Merged
merged 2 commits into from
May 4, 2022

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented May 3, 2022

What I did

Bug where you needed to be connected to a provider to see accounts, causing ape ledger list to not work.
This was a regression from the change in ape but somehow did not fail the tests?? I am not sure how.

How I did it

How to verify it

Tests pass again.
Can use ape ledger list

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as draft May 3, 2022 22:22
@antazoey antazoey marked this pull request as ready for review May 3, 2022 22:23
@antazoey antazoey requested a review from fubuloubu May 3, 2022 22:39
@antazoey antazoey merged commit 31a2ecb into main May 4, 2022
@antazoey antazoey deleted the fix/jules-dont-require-connection branch May 4, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants