fix: accidentally was skipping ExecutedTxData because it was a subclass

ApeWorX · Jun 6, 2024 · d55b664 · d55b664
1 parent a37a958
commit d55b664
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/ape_safe/client/base.py b/ape_safe/client/base.py
@@ -96,7 +96,8 @@ def get_transactions(
                 elif confirmed and not is_confirmed:
                     continue  # NOTE: Skip not confirmed transactions
 
-            if txn.nonce < next_nonce and isinstance(txn, UnexecutedTxData):
+            # NOTE: use `type(txn) is ...` because ExecutedTxData is a subclass of UnexecutedTxData
+            if txn.nonce < next_nonce and type(txn) is UnexecutedTxData:
                 continue  # NOTE: Skip orphaned transactions
 
             if filter_by_ids and txn.safe_tx_hash not in filter_by_ids: