Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: empty raises [APE-1378] #22

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: empty raises [APE-1378] #22

merged 1 commit into from
Sep 7, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 7, 2023

What I did

no exception on stack errors that would happen
use real errors.

How I did it

ValueError made sense once.
TypeError made sense once.
A new custom error made sense once.

How to verify it

exceptions are better

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: empty raises fix: empty raises [APE-1378] Sep 7, 2023
@antazoey antazoey requested a review from dtdang September 7, 2023 17:30
@dtdang dtdang merged commit 1550367 into ApeWorX:main Sep 7, 2023
13 checks passed
@antazoey antazoey deleted the feat/exceptions branch September 7, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtdang dtdang dtdang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @dtdang