feat: sign eip-712 message instead of hash #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see also https://docs.safe.global/advanced/smart-account-signatures
What I did
sign eip-712 message instead of defunct message.
if you follow the naming in safe docs, i have switched
eth_sign
signature for ecdsa signature.it has also allowed to remove the method to adjust
v
of the signature.fixes: #54
How I did it
replace signing of
safe_tx_hash
with signing ofsafe_tx
.How to verify it
Checklist