fix: weird repr of token manager [APE-1241] #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
antazoey
commented
Jul 28, 2023
| @@ -110,11 +110,8 @@ class TokenManager(ManagerAccessMixin, dict): | |||
| def _manager(self) -> TokenListManager: | |||
| return TokenListManager() | |||
|
|
|||
| @cached_property | |||
There was a problem hiding this comment.
that was no longer used and it is an internal property
dtdang
approved these changes
Jul 28, 2023
fubuloubu
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The
TokenManager's repr is just{}which is kinda weird, makes it seem like you don't have any tokenlists installed or something even though that is not the case. Better to just use<ape_tokens.TokenManager>so that is what this PR does.P.s. trying to figure out how to get USD of tokens
How I did it
How to verify it
Checklist