Skip to content

Commit

Permalink
fix: remove direct install from setup file (#1267)
Browse files Browse the repository at this point in the history
  • Loading branch information
antazoey authored Jan 31, 2023
1 parent af957ea commit 053db7b
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/commitlint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Dependencies
run: |
python -m pip install --upgrade pip
pip install .[dev]
pip install -r cz-requirement.txt
- name: Check commit history
run: cz check --rev-range $(git rev-list --all --reverse | head -1)..HEAD
4 changes: 4 additions & 0 deletions .github/workflows/docs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ jobs:
- name: Install Dependencies
run: |
python -m pip install --upgrade pip
# TODO: Remove once we have re-added Myst-Parser to setup.py (post sphinx 6 support)
pip install git+https://github.com/executablebooks/MyST-Parser.git
pip install .[doc]
- name: Build HTML artifact
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prtitle.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Install Dependencies
run: |
python -m pip install --upgrade pip
pip install .[dev]
pip install -r cz-requirement.txt
- name: Check PR Title
env:
Expand Down
1 change: 1 addition & 0 deletions cz-requirement.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
commitizen>=2.40,<2.41
7 changes: 4 additions & 3 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
],
"doc": [
# Tools for parsing markdown files in the docs
"myst-parser @ git+https://github.com/executablebooks/MyST-Parser.git",
# "myst-parser", # TODO: Uncomment/re-pin once Sphinx 6 support is released
"sphinx-click>=4.4.0,<5.0", # For documenting CLI
"Sphinx>=6.1.3,<7.0", # Documentation generator
"sphinx_rtd_theme>=1.2.0rc3,<2", # Readthedocs.org theme
Expand All @@ -47,15 +47,16 @@
"twine==3.8.0", # Package upload tool
],
"dev": [
"commitizen>=2.19,<2.20", # Manage commits and publishing releases
# commitizen: Manage commits and publishing releases
(here / "cz-requirement.txt").read_text().strip(),
"pre-commit", # Ensure that linters are run prior to committing
"pytest-watch", # `ptw` test watcher/runner
"ipdb", # Debugger (Must use `export PYTHONBREAKPOINT=ipdb.set_trace`)
],
# NOTE: These are extras that someone can install to get up and running quickly w/ ape
# They should be kept up to date with what works and what doesn't out of the box
# Usage example: `pipx install eth-ape[recommended-plugins]`
"recommended-plugins": (here / "recommended-plugins.txt").read_text().split("\n"),
"recommended-plugins": (here / "recommended-plugins.txt").read_text().splitlines(),
}

# NOTE: `pip install -e .[dev]` to install package
Expand Down

0 comments on commit 053db7b

Please sign in to comment.