fix: issue with default txn type and hyphen (#1275)

ApeWorX · Feb 1, 2023 · 97264ed · 97264ed
1 parent 41f0018
commit 97264ed
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/ape_ethereum/ecosystem.py b/src/ape_ethereum/ecosystem.py
@@ -174,7 +174,8 @@ def config(self) -> EthereumConfig:
 
     @property
     def default_transaction_type(self) -> TransactionType:
-        return self.config[self.default_network].default_transaction_type
+        network = self.default_network.replace("-", "_")
+        return self.config[network].default_transaction_type
 
     @classmethod
     def decode_address(cls, raw_address: RawAddress) -> AddressType:

diff --git a/tests/functional/test_ecosystem.py b/tests/functional/test_ecosystem.py
@@ -4,6 +4,7 @@
 from eth_typing import HexAddress, HexStr
 from hexbytes import HexBytes
 
+from ape.api.networks import LOCAL_NETWORK_NAME
 from ape.types import AddressType
 from ape.utils import DEFAULT_LOCAL_TRANSACTION_ACCEPTANCE_TIMEOUT
 from ape_ethereum.ecosystem import Block
@@ -186,7 +187,10 @@ def test_decode_receipt(eth_tester_provider, ethereum):
 
 
 def test_configure_default_txn_type(temp_config, ethereum):
-    config_dict = {"ethereum": {"local": {"default_transaction_type": 0}}}
+    config_dict = {"ethereum": {"mainnet_fork": {"default_transaction_type": 0}}}
     assert ethereum.default_transaction_type == TransactionType.DYNAMIC
+
     with temp_config(config_dict):
+        ethereum._default_network = "mainnet-fork"
         assert ethereum.default_transaction_type == TransactionType.STATIC
+        ethereum._default_network = LOCAL_NETWORK_NAME