fix: .return_value bugs with tuples, structs, and length
#2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
fix/always-use-calltree
branch
from
d340daa
to
c9bc472
Compare
antazoey
force-pushed
the
fix/always-use-calltree
branch
from
8fd804b
to
9463a70
Compare
antazoey
force-pushed
the
fix/always-use-calltree
branch
from
585bb6a
to
4d7fb56
Compare
bitwise-constructs
previously approved these changes
Aug 26, 2024
fubuloubu
previously approved these changes
Aug 26, 2024
fubuloubu
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Always use call-tree approach since debug_tt approach for complex values seems bugged (for now) and super hard to do correctly as the rhymthe and reason disappears when using hardhat.
How I did it
rely on calltree
How to verify it
ugh, see my test, had to copy in a bunch of raw data because was hard to get into to be bad in a simple way.
Checklist