perf: make ape run --help faster
#2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ape run --helpwas still slow because of a few reasons, mostly was the project access that i may look into on another PR.How I did it
Use
Path.cwd()/ "scripts"` locally.Localize some imports as well.
Note: if you have a script module that is just slow to load, this wont help that ofc
How to verify it
(in a project with zero scripts)
BEFORE:
AFTER:
With scripts is also much faster, but you wil only be as fast as your slowest script to load in a project. CLI users should have the same knowledge that lazy imports are better for CLIs.
Checklist