Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: localize import for ape console #2374

Merged
merged 2 commits into from
Nov 5, 2024
Merged

perf: localize import for ape console #2374

merged 2 commits into from
Nov 5, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 4, 2024

What I did

accidentally did a top level import in #2370
which caused a significant enough slow down to all of ape --help

ape --help  1.30s user 0.17s system 60% cpu 2.425 total

ape --help  0.95s user 0.13s system 57% cpu 1.887 total

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey enabled auto-merge (squash) November 5, 2024 14:36
@antazoey antazoey merged commit 04ac2f1 into ApeWorX:main Nov 5, 2024
16 checks passed
@antazoey antazoey deleted the perf/whoopsie-on-console branch November 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@bitwise-constructs bitwise-constructs Awaiting requested review from bitwise-constructs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu