Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cluster and workspace form data #139

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: cluster and workspace form data #139

merged 1 commit into from
Oct 18, 2024

Conversation

dtdang
Copy link
Contributor

@dtdang dtdang commented Oct 18, 2024 •
edited
Loading

What I did

Fixes the cluster & Workspace create/update must use Form encoded data, not JSON body (use data= instead of json=)

fixes: #137

How I did it

How to verify it

Tested creating clusters with cli and it works.

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@dtdang dtdang requested a review from fubuloubu October 18, 2024 20:17
@fubuloubu fubuloubu merged commit 3619530 into ApeWorX:main Oct 18, 2024
14 checks passed
@dtdang dtdang deleted the fix/cluster_form branch October 18, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Platform launch fixes
2 participants
@dtdang @fubuloubu