Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workspace subcommands #148
feat: add workspace subcommands #148
Changes from 10 commits
de125b7
b581cd8
de54c53
60075df
b992fb9
581df36
eed3d5e
763f86a
5fb963f
697e2a2
1c7ca7d
babc277
e5a4c69
930e55d
ebf0c66
2693687
300838e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user doesn't have an update name or slug, it seems like it won't keep the previous name/slug. At least that was the case when I tried it using the
/docs/
page, or was that a bug?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so if both are empty, it should raise
UsageError
because you haven't tried to update anythingare you saying if one is empty and the other is intended to be changed, they both update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Originally it was if one is empty and the other is intended then they both updated. The new push I made should have fixed that issue though I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the service itself should allow
None
values and basically make it "no change required", so you shouldn't have to set the values if they are not set and it should work appropiatelymy point above is that if both are
None
that is a no-op (won't make any change when you send the PATCH request to the service) so it should raiseclick.UsageError
that it's a no-opThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to update just one value of both
name
andslug
but if a value is left asNone
then the value will be patched in the workspace as''
.Added the
click.UsageError
if both values areNone
.