fix: better local default for new_block_timeout
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotPeopling2day
approved these changes
Aug 10, 2023
| self.chain_manager.provider.network.name.endswith("-fork") | ||
| or self.chain_manager.provider.network.name == LOCAL_NETWORK_NAME | ||
| ): | ||
| settings.NEW_BLOCK_TIMEOUT = int(timedelta(days=1).total_seconds()) |
There was a problem hiding this comment.
I'm approving, but playing catch-up here and don't have proper context, please excuse my ignorance. If it's local or not provided we set the time out to a day? What scenario or setup might trigger this, or would there be a different value to consider?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
help prevent unnecessary timeouts
How I did it
How to verify it
Checklist