Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow configuring the runner class [SBK-233] #29

Merged
merged 10 commits into from
Aug 22, 2023
Merged

feat: allow configuring the runner class [SBK-233] #29

merged 10 commits into from
Aug 22, 2023

Conversation

fubuloubu
Copy link
Member

What I did

Allows configuring a custom runner class

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat: allow configuring the runner class feat: allow configuring the runner class [SBK-233] Aug 21, 2023
@linear
Copy link

linear bot commented Aug 21, 2023

SBK-233 "feat: allow configuring the runner class" (ApeWorX/silverback #29)

What I did

Allows configuring a custom runner class

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

ApeWorX/silverback #29 by fubuloubu on GitHub

via LinearSync

@fubuloubu fubuloubu marked this pull request as ready for review August 21, 2023 17:56
antazoey
antazoey previously approved these changes Aug 21, 2023
View reviewed changes
antazoey
antazoey reviewed Aug 21, 2023
View reviewed changes
silverback/_cli.py Outdated Show resolved Hide resolved
antazoey
antazoey reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments now that i tried to use

silverback/_cli.py Outdated Show resolved Hide resolved
antazoey
antazoey reviewed Aug 22, 2023
View reviewed changes
silverback/runner.py Outdated Show resolved Hide resolved
antazoey
antazoey previously approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but @fubuloubu let me know if the additions (subtractions?) are ok, and then we can release this.

fubuloubu
fubuloubu commented Aug 22, 2023
View reviewed changes
Copy link
Member Author

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@antazoey antazoey enabled auto-merge (squash) August 22, 2023 15:43
@antazoey antazoey merged commit 921341c into main Aug 22, 2023
20 checks passed
@antazoey antazoey deleted the feat/configure-runner branch August 22, 2023 15:43
@fubuloubu fubuloubu mentioned this pull request Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fubuloubu @antazoey