Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tokens temp fix when USDC not in tokenlists [SBK-240] #31

Closed
wants to merge 1 commit into from

Conversation

antazoey
Copy link
Member

What I did

until we have our own tokenlist, this allows the example to work on optimism and arby

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title fix: tokens temp fix when USDC not in tokenlists fix: tokens temp fix when USDC not in tokenlists [SBK-240] Aug 22, 2023
@fubuloubu
Copy link
Member

I think that the example should just be simple and work only on mainnet ethereum

@antazoey antazoey closed this Sep 11, 2023
@antazoey antazoey deleted the fix/tokens branch December 20, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants