Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement CancellationTokenSourcePool #1192

Merged
merged 4 commits into from
May 17, 2023

Conversation

martintmk
Copy link
Contributor

@martintmk martintmk commented May 17, 2023

Details on the issue fix or feature implementation

This PR changes the way the CancellationTokenSourcePool works to allign better with the .NET 8 TimeProvider.

Unblock further work on #1144

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@martintmk martintmk added the v8 Issues related to the new version 8 of the Polly library. label May 17, 2023
@martintmk martintmk added this to the v8.0.0 milestone May 17, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1192 (772f598) into main (f4d5347) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
+ Coverage   83.39%   83.44%   +0.05%     
==========================================
  Files         273      275       +2     
  Lines        6316     6336      +20     
  Branches     1027     1031       +4     
==========================================
+ Hits         5267     5287      +20     
  Misses        844      844              
  Partials      205      205              
Flag Coverage Δ
linux ?
macos 83.44% <100.00%> (+0.05%) ⬆️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Polly.Core/Hedging/Controller/HedgingController.cs 100.00% <100.00%> (ø)
src/Polly.Core/Hedging/Controller/TaskExecution.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Timeout/TimeoutResilienceStrategy.cs 100.00% <100.00%> (ø)
...re/Utils/CancellationTokenSourcePool.Disposable.cs 100.00% <100.00%> (ø)
...y.Core/Utils/CancellationTokenSourcePool.Pooled.cs 100.00% <100.00%> (ø)
...rc/Polly.Core/Utils/CancellationTokenSourcePool.cs 100.00% <100.00%> (ø)

@martintmk martintmk enabled auto-merge (squash) May 17, 2023 13:22
@martintmk martintmk merged commit a4343b7 into main May 17, 2023
@martintmk martintmk deleted the mtomka/cancellationtokensourcepool branch May 17, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants