Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds gh-pages support #1582

Merged
merged 67 commits into from
Sep 15, 2023
Merged

Adds gh-pages support #1582

merged 67 commits into from
Sep 15, 2023

Conversation

adamnova
Copy link
Contributor

@adamnova adamnova commented Sep 12, 2023

The issue or feature being addressed

Introduces support for Github Pages for Polly using DocFx.

Details on the issue fix or feature implementation

Addresses #1561

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e69ec3) 83.99% compared to head (06aaf7a) 83.99%.

❗ Current head 06aaf7a differs from pull request most recent head 3ed859f. Consider uploading reports for the commit 3ed859f to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           docs/gh-pages    #1582   +/-   ##
==============================================
  Coverage          83.99%   83.99%           
==============================================
  Files                280      280           
  Lines               6548     6548           
  Branches            1020     1020           
==============================================
  Hits                5500     5500           
  Misses               839      839           
  Partials             209      209           
Flag Coverage Δ
macos 83.99% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martintmk martintmk changed the base branch from main to docs/gh-pages September 15, 2023 13:27
@adamnova adamnova marked this pull request as ready for review September 15, 2023 13:29
@martintmk martintmk merged commit b02daa9 into App-vNext:docs/gh-pages Sep 15, 2023
2 checks passed
martintmk pushed a commit that referenced this pull request Sep 18, 2023
@martincostello martincostello added this to the v8.0.0 milestone Sep 25, 2023
@martincostello martincostello added v8 Issues related to the new version 8 of the Polly library. documentation labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation v8 Issues related to the new version 8 of the Polly library.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants