-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] General extensibility and implementation of proactive strategies #1602
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1602 +/- ##
=======================================
Coverage 84.63% 84.63%
=======================================
Files 306 306
Lines 6820 6820
Branches 1044 1044
=======================================
Hits 5772 5772
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
public TimingStrategyOptions() | ||
{ | ||
// It's recommended to set the default name for the options so | ||
// the consumer can get additional information in the telemetry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What additional information? If it's just the name I would probably say "the consumer can see it in the telemetry" if it allows access to more things, an example could be handy to help build a picture.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reworded slightly.
Details on the issue fix or feature implementation
Contributes to #1091
Confirm the following