Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.8.0 #587

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Release 1.8.0 #587

merged 6 commits into from
Jun 5, 2024

Conversation

jakubnowicki
Copy link
Member

Description

  • bump package version
  • add Rhino 1.8 migration guide

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@jakubnowicki jakubnowicki requested a review from radbasa June 5, 2024 09:47
Copy link
Contributor

@radbasa radbasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of questions.

NEWS.md Show resolved Hide resolved
vignettes/how-to/migrate-1-8.Rmd Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.65%. Comparing base (d4d1bc7) to head (8233a96).

Current head 8233a96 differs from pull request most recent head b3ab9a4

Please upload reports for the commit b3ab9a4 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #587   +/-   ##
=======================================
  Coverage   20.65%   20.65%           
=======================================
  Files           9        9           
  Lines         460      460           
=======================================
  Hits           95       95           
  Misses        365      365           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakubnowicki jakubnowicki merged commit dd901d0 into main Jun 5, 2024
10 checks passed
@jakubnowicki jakubnowicki deleted the release-1.8.0 branch June 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants