Use before_navbar to fix the double search box
#604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `pkgdown/build.R` script used to replace the `navbar.html` template
in order to add a documentation version switcher to the navbar.
However, this solution broke down when the template was updated in {pkgdown}.
Fix: use `template.includes.before_navbar` to inject the version switcher
instead of overwriting the navbar template.
This solution has a chance of being more robust
against future updates to the template.
TymekDev
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #601.
The
pkgdown/build.Rscript used to replace thenavbar.htmltemplate in order to add a documentation version switcher to the navbar. However, this solution broke down when the template was updated in {pkgdown}.Fix: use
template.includes.before_navbarto inject the version switcher instead of overwriting the navbar template. This solution has a chance of being more robust against future updates to the template.Testing
I have tested this solution in a forked repo and it seems to work fine. See the bot/github-pages branch there.