Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import fixes #46

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Import fixes #46

merged 1 commit into from
Jul 17, 2024

Conversation

keithchev
Copy link
Member

@keithchev keithchev commented Jul 17, 2024 •
edited
Loading

This PR addresses #40 and also removes the star imports in the top-level __init__ in favor of explicit imports (and adds them to __all__).

@keithchev keithchev requested a review from mezarque July 17, 2024 17:20
mezarque
mezarque approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mezarque mezarque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@keithchev keithchev merged commit 86dd458 into main Jul 17, 2024
1 check passed
@keithchev keithchev deleted the kcc/remove-hexcode-from-colors-all branch July 17, 2024 18:18
@keithchev keithchev mentioned this pull request Jul 17, 2024
Merged
@mezarque mezarque mentioned this pull request Aug 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mezarque mezarque mezarque approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keithchev @mezarque