Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the reasoning for the proposed change from the original post:
I tried to line 647 in reader.py from:
to:
To tell whether channel is the second dimension, the original code tries to do so by comparing the "byte jump" ("BytesInc" attribute of channels) to the "BytesInc" of z dimension.
In my humble opinion, I feel it is more reasonable to tell by checking the value of "BytesInc" of z dimension. In my case, both the x and y axis size are 1024 pixels with 16 bits depth. With "BytesInc" of z dimension being 12582912 (1024 * 1024 * 2 * 6) I feel channel should not be the second dimension...
The original comment is here: #44 (comment)
I have tested with couples of images I have and results turned out to be correct it seemed.
If possible, would you please do perform a more extensive test before the merge?
Thanks a lot!
Alan