Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make production ready #136

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Make production ready #136

merged 5 commits into from
Aug 11, 2023

Conversation

mekarpeles
Copy link
Member

@mekarpeles mekarpeles commented Aug 9, 2023 •
edited
Loading

  • ✂️ Removes unused codepaths in presentation-v3 (labs only)
  • ♻️ Replaces hard-coded constants with overridable vars from config / settings

@mekarpeles mekarpeles temporarily deployed to development August 9, 2023 19:53 — with GitHub Actions Inactive
@mekarpeles mekarpeles temporarily deployed to development August 9, 2023 19:57 — with GitHub Actions Inactive
@mekarpeles mekarpeles changed the title Update resolver.py Make production ready Aug 9, 2023
@mekarpeles mekarpeles temporarily deployed to development August 9, 2023 20:01 — with GitHub Actions Inactive
@mekarpeles mekarpeles temporarily deployed to development August 9, 2023 20:07 — with GitHub Actions Inactive
@mekarpeles mekarpeles marked this pull request as ready for review August 10, 2023 21:51
digitaldogsbody
digitaldogsbody approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@digitaldogsbody digitaldogsbody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

glenrobson
glenrobson approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@glenrobson glenrobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too.

@mekarpeles mekarpeles merged commit 5345581 into presentation-v3 Aug 11, 2023
3 checks passed
@mekarpeles mekarpeles deleted the production-rc1 branch August 11, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glenrobson glenrobson glenrobson approved these changes

@digitaldogsbody digitaldogsbody digitaldogsbody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mekarpeles @glenrobson @digitaldogsbody