Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect cancelled drops #308

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Respect cancelled drops #308

merged 1 commit into from
Sep 29, 2024

Conversation

masmc05
Copy link
Contributor

@masmc05 masmc05 commented Jul 30, 2024

Currently if other plugins cancel block drops, some drop will still happen due to the fact that an ability is doubling the drop. This pr fixes that and if other plugins cancel the drops then AuraSkills will not try to drop anything

@Archy-X
Copy link
Owner

Archy-X commented Aug 3, 2024

This could cause issues with plugins that directly add drops to the player's inventory, which would prevent AuraSkills from doing the same with extra drops. I'm cautious to merge this until this behavior is confirmed to be preserved.

@masmc05
Copy link
Contributor Author

masmc05 commented Aug 14, 2024

Plugins that does that should use https://jd.papermc.io/paper/1.21.1/org/bukkit/event/block/BlockDropItemEvent.html#getItems() instead of this event

Even AuraSkills is misusing the break event to add some drops, as this should have been a separate event with a proper method

@Archy-X Archy-X merged commit a45ebaa into Archy-X:master Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants