Add option to disable optimized multiplier permission lookup #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Archy-X
requested changes
Aug 5, 2024
bukkit/src/main/java/dev/aurelium/auraskills/bukkit/hooks/BukkitLuckPermsHook.java
Outdated
Show resolved
Hide resolved
Archy-X
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luckperms doesn't have any event for permission changes based on the permission nodes contexts.
This means the current cache won't take into account when a multiplier is added/removed based on contexts.
For example, if you use ExtraContexts, or any other built-in LP contexts the cache probably wouldn't work.
I didn't want to remove the entire feature, since it is probably useful for many large servers. Most people only use the server context which doesn't change on the same server. Instead, I made a config option to disable the feature if necessary.