Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update transaction type handling #1000

Merged

Conversation

alexbarnsley
Copy link
Member

@alexbarnsley alexbarnsley commented Nov 13, 2024

Summary

https://app.clickup.com/t/86dv4f3wp

requires/merging into #999 as the homepage is currently broken without it

todo:

  • remove sub-category - relies on the isLegacy method which should no longer be applicable
  • follow on from above - remove isLegacy handling
  • handle voted validator?
  • handle unvoted validator? - trickier as the validator isn't passed into the contract method
  • remove or comment out other transaction types which aren't supported yet
  • show method hash if no match for transaction type
  • address wrapping on vote tooltips

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Base automatically changed from fix/handle-missing-state-record to mainsail-develop November 13, 2024 08:39
@alexbarnsley alexbarnsley changed the title [WIP] refactor: update transaction type handling refactor: update transaction type handling Nov 14, 2024
@ItsANameToo ItsANameToo merged commit 6610cd0 into mainsail-develop Nov 14, 2024
8 of 9 checks passed
@ItsANameToo ItsANameToo deleted the refactor/update-transaction-type-handling branch November 14, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants