-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update transaction type handling #1000
Merged
ItsANameToo
merged 23 commits into
mainsail-develop
from
refactor/update-transaction-type-handling
Nov 14, 2024
Merged
refactor: update transaction type handling #1000
ItsANameToo
merged 23 commits into
mainsail-develop
from
refactor/update-transaction-type-handling
Nov 14, 2024
+603
−4,829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a payload instead
…m:ArdentHQ/arkscan into refactor/update-transaction-type-handling
Base automatically changed from
fix/handle-missing-state-record
to
mainsail-develop
November 13, 2024 08:39
alexbarnsley
changed the title
[WIP] refactor: update transaction type handling
refactor: update transaction type handling
Nov 14, 2024
alexbarnsley
requested review from
boldninja,
ItsANameToo and
samharperpittam
as code owners
November 14, 2024 14:54
ItsANameToo
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://app.clickup.com/t/86dv4f3wp
requires/merging into #999 as the homepage is currently broken without it
todo:
isLegacy
method which should no longer be applicableisLegacy
handlingChecklist