Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: calculate fees #994

Merged
merged 18 commits into from
Nov 12, 2024
Merged

Conversation

alexbarnsley
Copy link
Member

Summary

https://app.clickup.com/t/86dv41828

Checklist

  • I checked my UI changes against the design and there are no notable differences
  • I checked my UI changes for any responsiveness issues
  • I checked my UI changes in light AND dark mode
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@alexbarnsley alexbarnsley changed the base branch from develop to mainsail-develop November 8, 2024 13:35
app/Models/Transaction.php Outdated Show resolved Hide resolved
app/ViewModels/TransactionViewModel.php Outdated Show resolved Hide resolved
app/Models/Transaction.php Outdated Show resolved Hide resolved
@alexbarnsley alexbarnsley changed the title [wip] refactor: calculate fees refactor: calculate fees Nov 11, 2024
@alexbarnsley alexbarnsley marked this pull request as ready for review November 11, 2024 18:32
@ItsANameToo ItsANameToo merged commit 9340474 into mainsail-develop Nov 12, 2024
12 of 14 checks passed
@ItsANameToo ItsANameToo deleted the refactor/calculate-fees branch November 12, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants