Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add border when no load more button is shown #764

Merged
merged 8 commits into from
Oct 24, 2024
Merged

refactor: add border when no load more button is shown #764

merged 8 commits into from
Oct 24, 2024

Conversation

patricio0312rev
Copy link
Contributor

[transaction tables] add bottom border when no "Load More" button

Summary

  • Bottom border is now being shown when no "Load more" button is present in the transactions table.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Oct 23, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 24, 2024 10:53am

@ItsANameToo ItsANameToo changed the base branch from develop to rc-1.17.0 October 24, 2024 09:16
@ItsANameToo ItsANameToo modified the milestones: 1.18.0, 1.17.0 Oct 24, 2024
samharperpittam
samharperpittam requested changes Oct 24, 2024
View reviewed changes
Copy link

@samharperpittam samharperpittam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The border is still in view when the Load More button is present

image

@samharperpittam samharperpittam marked this pull request as draft October 24, 2024 10:17
@ItsANameToo ItsANameToo marked this pull request as ready for review October 24, 2024 10:49
@patricio0312rev patricio0312rev merged commit 19dd04f into rc-1.17.0 Oct 24, 2024
20 checks passed
@patricio0312rev patricio0312rev deleted the refactor/border-bottom-on-no-load-more-button branch October 24, 2024 11:56
shahin-hq pushed a commit that referenced this pull request Oct 28, 2024
@patricio0312rev @ItsANameToo @shahin-hq
refactor: add border when no load more button is shown (#764)
e635d65 
Co-authored-by: ItsANameToo <[email protected]>
Co-authored-by: ItsANameToo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahin-hq shahin-hq shahin-hq approved these changes

@samharperpittam samharperpittam samharperpittam approved these changes

@ItsANameToo ItsANameToo Awaiting requested review from ItsANameToo ItsANameToo is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @samharperpittam @shahin-hq @ItsANameToo