Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: form label hover on delete modal #765

Merged
merged 12 commits into from
Oct 28, 2024
Merged

refactor: form label hover on delete modal #765

merged 12 commits into from
Oct 28, 2024

Conversation

patricio0312rev
Copy link
Contributor

[delete wallet modal] don't change Wallet title colour on hover

Summary

  • FormField component has been refactored and now supports the disableHover prop.
  • The hover effect for the "Delete Wallet" modal has been disabled.
image

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@vercel Vercel
Copy link

vercel bot commented Oct 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 26, 2024 2:17am

@patricio0312rev patricio0312rev added this to the 1.18.0 milestone Oct 24, 2024
@shahin-hq
Copy link
Contributor

shahin-hq commented Oct 24, 2024 •
edited
Loading

We've been removing the avatar, it seems Delete Modal is overlooked, this might be irrelevant depending on the new design
cc @samharperpittam

@samharperpittam
Copy link

samharperpittam commented Oct 24, 2024 •
edited
Loading

Yeah good shout @shahin-hq

See design here:

image

Can you remove the avatar too please @patricio0312rev ?

@samharperpittam samharperpittam marked this pull request as draft October 24, 2024 14:41
@patricio0312rev patricio0312rev marked this pull request as ready for review October 26, 2024 02:43
@patricio0312rev
Copy link
Contributor Author

Should be fixed now 🌟 @samharperpittam

@ItsANameToo ItsANameToo merged commit 3349a92 into develop Oct 28, 2024
39 checks passed
@ItsANameToo ItsANameToo deleted the refactor/form-label-hover branch October 28, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

@samharperpittam samharperpittam Awaiting requested review from samharperpittam samharperpittam is a code owner

@goga-m goga-m Awaiting requested review from goga-m goga-m is a code owner

@boldninja boldninja Awaiting requested review from boldninja boldninja is a code owner

@alexbarnsley alexbarnsley Awaiting requested review from alexbarnsley alexbarnsley is a code owner

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@patricio0312rev @shahin-hq @samharperpittam @ItsANameToo