Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests port usage #767

Merged
merged 2 commits into from
Oct 24, 2024
Merged

fix: e2e tests port usage #767

merged 2 commits into from
Oct 24, 2024

Conversation

ItsANameToo
Copy link
Contributor

@ItsANameToo ItsANameToo commented Oct 24, 2024

Summary

https://app.clickup.com/t/86dv00p0p

adjusts the port to 5001 to avoid issues on Mac where port 5000 is used by default + hopefully fixes the intermittent issue with github CI as well

Edit: they are now running sequentially to help e2e run one at a time as opposed to them all together

Checklist

  • My changes look good in both light AND dark mode
  • The change is not hardcoded to a single network, but has multi-asset in mind
  • I checked my changes for obvious issues, debug statements and commented code
  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arkvault ✅ Ready (Inspect) Visit Preview Oct 24, 2024 9:43am

@ItsANameToo ItsANameToo merged commit f271a83 into rc-1.17.0 Oct 24, 2024
21 of 22 checks passed
@ItsANameToo ItsANameToo deleted the fix/e2e-tests branch October 24, 2024 09:58
@ItsANameToo ItsANameToo added this to the 1.17.0 milestone Oct 24, 2024
shahin-hq pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant